Skip to content

Extended corner usage#87

Merged
fmalatino merged 9 commits into
NOAA-GFDL:developfrom
twicki:extended_corner_usage
Oct 10, 2025
Merged

Extended corner usage#87
fmalatino merged 9 commits into
NOAA-GFDL:developfrom
twicki:extended_corner_usage

Conversation

@twicki
Copy link
Copy Markdown
Collaborator

@twicki twicki commented Sep 24, 2025

Description
This is the follow-up PR of NOAA-GFDL/NDSL#240. In there, we deprecated the old corner-code in NDSL. Here , we enable a better-perfoming verison of CopyCorners written in plain python.

This also streamlines the copy_corners_[X/Y]_nord implementation to not re-implement the full logic but re-use the logic implemened.

📣 This changes the previously errenous implementation of the nord check and now - as was in fortran - implements the comparison to 0 instead of the current_nord. This oversight was never caught because the loop iteration and the value were always far enough away from each other, but this is true to what the original model-code did.

How has this been tested?

Ran orchestrated & non-orchestrated regression tests (CopyCorners / FvTp2d and Del6VtFlux)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • Targeted model if this changed was triggered by a model need/shortcoming

@romanc romanc mentioned this pull request Sep 26, 2025
@FlorianDeconinck
Copy link
Copy Markdown
Collaborator

Let's add a n_halo check to 3.

@twicki twicki marked this pull request as ready for review October 8, 2025 15:40
Copy link
Copy Markdown
Collaborator

@romanc romanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@romanc
Copy link
Copy Markdown
Collaborator

romanc commented Oct 10, 2025

@fmalatino / @jjuyeonkim: This is the optimized corner code that we were talkkng about today in the sync meeting. We'll need your help merging here since we don't have permission to do so.

@fmalatino fmalatino added this pull request to the merge queue Oct 10, 2025
Merged via the queue into NOAA-GFDL:develop with commit ca99584 Oct 10, 2025
4 checks passed
romanc added a commit to romanc/PyFV3 that referenced this pull request Oct 27, 2025
Follow-up from PR NOAA-GFDL#87, let's use the new corner implementation.
@romanc romanc mentioned this pull request Oct 27, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants